Use ES build instead of xpack inside xpack info action #122859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class.
rjernst
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Feb 18, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
Nice! Minimal, but effective.
This was referenced Feb 18, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 18, 2025
Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 18, 2025
Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class.
Collaborator
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 18, 2025
Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
…2868) Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
…2869) Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
…2867) Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implemntation to look at the Elasticsearch build details, and removes the xpack build info class. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xpack used to be a plugin to Elasticsearch, and existed in a separate repository. So it had a separate build hash and date, which is exposed through the xpack info API. Since xpack is no longer a plugin, and part of the Elasticsearch repository, having a separate build info is no longer necessary. This commit keeps the xpack info content intact, but switches the implementation to look at the Elasticsearch build details, and removes the xpack build info class.