Skip selected tests in SSLErrorMessageFileTests that rely on SecurityManager #123484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Manager to block access to resources.
mosche
added
>test
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
Feb 26, 2025
Contributor
n1v0lg
left a comment
n1v0lg
left a comment
There was a problem hiding this comment.
LGTM -- as noted in the linked issue we also need to update prod code to handle NotEntitledException type exceptions.
mosche
added
the
auto-merge-without-approval
This was referenced Feb 26, 2025
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 26, 2025
…Manager to block access to resources. (elastic#123484) (cherry picked from commit 7e554fa)
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 26, 2025
…Manager to block access to resources. (elastic#123484)
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 26, 2025
…Manager to block access to resources. (elastic#123484) (cherry picked from commit 7e554fa)
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 26, 2025
…Manager to block access to resources. (elastic#123484)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 26, 2025
…Manager to block access to resources. (elastic#123484)
Collaborator
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 26, 2025
…Manager to block access to resources. (elastic#123484) (cherry picked from commit 7e554fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip selected tests in SSLErrorMessageFileTests that rely on SecurityManager to block access to resources.
Entitlement checks are not enabled for unit tests, but only when running Elasticsearch (e.g. in REST tests).
Relates to #121960