Skip to content

More entitlements for bouncycastle #123548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

More entitlements for bouncycastle #123548

merged 1 commit into from
Feb 27, 2025

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Feb 26, 2025

CI failures in #123511 demonstrated that there were a couple of entitlements missing for bouncycastle.

@prdoyle prdoyle added Team:Security Meta label for security team :Security/FIPS Running ES in FIPS 140-2 mode auto-backport Automatically create backport pull requests when merged test-entitlements v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Feb 26, 2025
@prdoyle prdoyle self-assigned this Feb 26, 2025
@prdoyle prdoyle requested a review from a team as a code owner February 26, 2025 20:54
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 26, 2025

Pinging @elastic/es-security (Team:Security)

@prdoyle
Copy link
Contributor Author

prdoyle commented Feb 26, 2025

Huh. This passed the -fips tests and the -entitlements tests, but I suspect there aren't any tests that did both.

@mark-vieira
Copy link
Contributor

mark-vieira commented Feb 26, 2025

Huh. This passed the -fips tests and the -entitlements tests, but I suspect there aren't any tests that did both.

You suspect correctly.

mosche
mosche approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mosche mosche merged commit a9e27a9 into elastic:main Feb 27, 2025
27 checks passed
This was referenced Feb 27, 2025
Merged
Merged
Merged
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Feb 27, 2025
@prdoyle
More entitlements for bouncycastle (elastic#123548)
494bfb3
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 27, 2025

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Feb 27, 2025
@prdoyle
More entitlements for bouncycastle (elastic#123548)
b35de34
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
@prdoyle
More entitlements for bouncycastle (#123548) (#123573)
1d15838
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
@prdoyle
More entitlements for bouncycastle (#123548) (#123574)
6ee55f3
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
@prdoyle
More entitlements for bouncycastle (#123548) (#123572)
5e619ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosche mosche mosche approved these changes

Assignees

@prdoyle prdoyle

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :Security/FIPS Running ES in FIPS 140-2 mode Team:Security Meta label for security team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prdoyle @elasticsearchmachine @mark-vieira @mosche