-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Query rules: Check if MGET request failed when we retrieve query rules #123616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query rules: Check if MGET request failed when we retrieve query rules #123616
Conversation
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for the failure case?
|
I am not sure how to add a test for this. I also looked at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing!
| - skip: | ||
| features: [ headers ] | ||
| - do: | ||
| headers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick - we probably can omit the headers for this test
closes #123429
when we retrieve the query ruleset, for each
MultiGetItemResponsethat represents a query rule, we need to explicitly check if retrieving the item failed.