[ML] Removing URL from inference API logs and adding the cause to the REST response #123638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
| l.onFailure( | ||
| createInternalServerError( | ||
| unwrappedException, | ||
| Strings.format("%s. Cause: %s", errorMessage, unwrappedException.getMessage()) |
There was a problem hiding this comment.
If the exception is not an ElasticsearchException we'll grab the cause to return to the API call. We've noticed in the case of apache timeout exceptions it would have been useful to return that information directly to the client instead of only logging it.
| this.model = Objects.requireNonNull(model); | ||
| this.sender = Objects.requireNonNull(sender); | ||
| this.account = new AlibabaCloudSearchAccount(this.model.getSecretSettings().apiKey()); | ||
| this.failedToSendRequestErrorMessage = constructFailedToSendRequestMessage(null, "AlibabaCloud Search completion"); |
There was a problem hiding this comment.
These changes are to remove the URL parameter.
|
|
||
| doAnswer(invocation -> { | ||
| @SuppressWarnings("unchecked") | ||
| ActionListener<InferenceServiceResults> listener = (ActionListener<InferenceServiceResults>) invocation.getArguments()[2]; |
There was a problem hiding this comment.
Now that we are including the cause I noticed that these tests where retrieving the wrong parameter.
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Feb 28, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Feb 28, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Feb 28, 2025
(cherry picked from commit 4dcc81f) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIEmbeddingsActionTests.java
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Feb 28, 2025
(cherry picked from commit 4dcc81f) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIEmbeddingsActionTests.java
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Feb 28, 2025
(cherry picked from commit 4dcc81f) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIEmbeddingsActionTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
(cherry picked from commit 4dcc81f) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIEmbeddingsActionTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
(cherry picked from commit 4dcc81f) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIEmbeddingsActionTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
) * Removing url and adding cause REST api response (#123638) (cherry picked from commit 4dcc81f) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/action/voyageai/VoyageAIEmbeddingsActionTests.java * Fixing errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error message that we return in the REST api call when performing inference using the inference API.
It also removes the URL from the message just in case it's getting logged.