More flexible settings pattern #123746
Merged
More flexible settings pattern #123746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
rjernst
added
:Core/Infra/Settings
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Feb 28, 2025
| new Path[] { Path.of("/data1"), Path.of("/data2") }, | ||
| new Path[] { Path.of("/shared1"), Path.of("/shared2") }, | ||
| Path.of("/tmp"), | ||
| setting -> settings.get(setting), |
There was a problem hiding this comment.
This will probably go away (you should get a compile error)
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 28, 2025
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 28, 2025
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 28, 2025
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks the settings globs to be more useable. Primarily it expands the values so that the settings may be lists, iterating over each value. Additionally it simplifies the function to also allow non-glob settings so that this single method may be used to lookup all values for a given setting pattern, whether it contains a glob or not.