Skip to content

Improve lookup join error messages in ES|QL #123813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improve lookup join error messages in ES|QL #123813

wants to merge 2 commits into from
+67 −3

Conversation

@JihwanByun
Copy link

@JihwanByun JihwanByun commented Mar 2, 2025 •
edited
Loading

Summary

Lookup index validity error message for ES|QL Imporved and Added unit tests for postAnalysisVerification to verify the behavior of LOOKUP JOIN validation.

Changes

  • Added tests to check the validation logic for LOOKUP JOIN in postAnalysisVerification
    • Ensures an error is raised when no valid fields exist (indexNameWithModes.size() == 0).
    • Ensures an error is raised when multiple indices are resolved (indexNameWithModes.size() > 1).
  • Uses EsRelation and Failures to simulate different index resolution scenarios.

Why?

@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Mar 2, 2025
@JihwanByun JihwanByun changed the title Improve lookup join error messages in ES|QL (#120189) Improve lookup join error messages in ES|QL Mar 2, 2025
@JihwanByun JihwanByun mentioned this pull request Mar 2, 2025
Closed
@JihwanByun JihwanByun force-pushed the Lookup-error-message-clarify branch from 5473e14 to ced420e Compare March 2, 2025 13:48
@kingherc kingherc added the :Analytics/ES|QL AKA ESQL label Mar 4, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Mar 4, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 4, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@costin
Copy link
Member

costin commented Mar 5, 2025

Thank you for the contribution however please be mindful of this section of the contributing guide as reviewing PRs carries a cost:

We normally immediately reject isolated PRs that only perform simple refactorings or otherwise "tidy up" certain aspects of the code. We think the benefits of this kind of change are very small, and in our experience it is not worth investing the substantial effort needed to review them.
This especially includes changes suggested by tools.

@costin costin closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JihwanByun @elasticsearchmachine @costin @kingherc