Do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions #123890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
reviewed
Mar 3, 2025
There was a problem hiding this comment.
What if we made a new exception type that implemented ElasticsearchWrapperException and always wrapped the exception caught by the failure handler? Something like SearchException in that it takes a message but also takes a cause, and the cause is used to determine the REST status. I see a few benefits to this approach:
- We can still insert a message indicating that the error happened when performing inference for semantic text, which helps for traceability.
- The REST status will always be indicative of the wrapped exception. For example, if the wrapped exception is
IllegalArgumentExceptionthe REST status will be 400.
WDYT?
…k_bubbleup_exceptions1
|
@Mikep86 your proposal sounds good to me, thanks! |
|
Hi @tteofili, I've created a changelog YAML for you. |
…elasticsearch into shardbulk_bubbleup_exceptions1
|
added new |
…k_bubbleup_exceptions1
Mikep86
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Nice simple approach, love it! Can we add a test showing that this works as expected?
Edit: We should be able to extend testItemFailures to cover this
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceException.java
Outdated
Show resolved
Hide resolved
Mikep86
reviewed
Mar 6, 2025
...ava/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterTests.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterTests.java
Outdated
Show resolved
Hide resolved
Mikep86
added
auto-backport
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Mikep86
approved these changes
Mar 7, 2025
This was referenced Mar 7, 2025
Merged
Merged
tteofili
added a commit
to tteofili/elasticsearch
that referenced
this pull request
Mar 7, 2025
elastic#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions
💔 Backport failed
You can use sqren/backport to manually backport by running |
tteofili
added a commit
to tteofili/elasticsearch
that referenced
this pull request
Mar 7, 2025
elastic#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions
tteofili
added a commit
to tteofili/elasticsearch
that referenced
this pull request
Mar 7, 2025
elastic#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions
Mikep86
pushed a commit
to Mikep86/elasticsearch
that referenced
this pull request
Mar 7, 2025
elastic#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions (cherry picked from commit 74bb0f9) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
pushed a commit
to Mikep86/elasticsearch
that referenced
this pull request
Mar 7, 2025
elastic#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions (cherry picked from commit 74bb0f9) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
…ceptions (#123890) (#124359) * Do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions (#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions (cherry picked from commit 74bb0f9) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java * Add missing import --------- Co-authored-by: Tommaso Teofili <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
…ceptions (#123890) (#124358) * Do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions (#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions (cherry picked from commit 74bb0f9) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java * Add missing import --------- Co-authored-by: Tommaso Teofili <[email protected]>
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
elastic#123890) * do not let ShardBulkInferenceActionFilter unwrap / rewrap ESExceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #123731