Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Mar 4, 2025

This change removes the skipping introduced for the semantic_text tests in #122222. These tests were accidentally re-enabled without failures over the last two weeks, so we can now re-enable them.

Closes #121411
Relates #122222

@dnhatn dnhatn added v9.0.1 v8.19.0 v8.18.1 :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests labels Mar 4, 2025
@dnhatn dnhatn requested review from alex-spies and ioanatia March 4, 2025 02:27
@dnhatn dnhatn added the auto-backport Automatically create backport pull requests when merged label Mar 4, 2025
@dnhatn dnhatn marked this pull request as ready for review March 4, 2025 02:28
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 4, 2025
Copy link
Contributor

@ioanatia ioanatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we won't need this check again 🙈 !

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnhatn !

@dnhatn
Copy link
Member Author

dnhatn commented Mar 4, 2025

@ioanatia @alex-spies Thanks!

@dnhatn dnhatn merged commit f956581 into elastic:main Mar 4, 2025
17 checks passed
@dnhatn dnhatn deleted the include-semantic-text branch March 4, 2025 15:32
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123948

georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
This change removes the skipping introduced for the semantic_text tests 
in elastic#122222. These tests were accidentally re-enabled without failures
over the last two weeks, so we can now re-enable them.

Closes elastic#121411
Relates elastic#122222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] EsqlSpecIT class failing

4 participants