Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Mar 4, 2025

Use the same exception class in more places where single lookup fails due to the existence of multiple projects. This allows the exception to be handled similarly, e.g. ignored in
ClusterApplierService#callClusterStateListener

Use the same exception class in more places where single lookup fails due
to the existence of multiple projects. This allows the exception to be
handled similarly, e.g. ignored in
ClusterApplierService#callClusterStateListener
@ywangd ywangd added >non-issue :Core/Infra/Core Core issues without another label v9.1.0 labels Mar 4, 2025
@ywangd ywangd requested review from a team and tvernum March 4, 2025 05:23
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ywangd
Copy link
Member Author

ywangd commented Mar 4, 2025

Note to reviewer: Please see serverless#3577 for context.

Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 4, 2025
@ywangd
Copy link
Member Author

ywangd commented Mar 4, 2025

@elasticmachine update branch

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 4, 2025
@elasticsearchmachine elasticsearchmachine merged commit 6646af0 into elastic:main Mar 5, 2025
16 checks passed
@ywangd ywangd deleted the use-multi-project-pending-exception-more-consistently branch March 5, 2025 00:38
dnhatn pushed a commit to dnhatn/elasticsearch that referenced this pull request Mar 5, 2025
Use the same exception class in more places where single lookup fails
due to the existence of multiple projects. This allows the exception to
be handled similarly, e.g. ignored in
ClusterApplierService#callClusterStateListener
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
Use the same exception class in more places where single lookup fails
due to the existence of multiple projects. This allows the exception to
be handled similarly, e.g. ignored in
ClusterApplierService#callClusterStateListener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >non-issue serverless-linked Added by automation, don't add manually Team:Core/Infra Meta label for core/infra team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants