Cleanup RegisteredDomainProcessor #124123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
CI passed, so I’m updating the branch now. |
This was referenced Mar 5, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 5, 2025
Collaborator
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 5, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 5, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 5, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 5, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #124118
This PR cleans up the
registered_domainprocessor implementation -- it passes with the tests as they are now, and it also passes with the rewritten tests on the linked PR.The biggest change here is that I've turned
DomainInfofrom astatic classinto arecord, and I tweakedgetRegisteredDomainso that it could becomestatic-- both of these changes will help with immensely with the next round of work that will follow this one.