Drop unused prefix and suffix from string collection utils
#124353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters are confusing and almost entirely unused (apart from one easily-adjusted test and two production locations where they are used incorrectly). This commit just removes them.
DaveCTurner
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nielsbauman
reviewed
Mar 7, 2025
| private static void appendCommaSeparatedSet(Set<String> items, StringBuilder sb) { | ||
| sb.append("["); | ||
| Strings.collectionToDelimitedString(items, ", ", "'", "'", sb); | ||
| Strings.collectionToDelimitedString(items, ", ", sb); |
Contributor
There was a problem hiding this comment.
Ah I missed this usage when I looked at your other PR - TBH I missed the whole method without the limit. Here there actually is a non-empty prefix and suffix... I'm inclined to think that it probably wouldn't have a huge effect if we don't wrap the items with single quotes, but technically we're changing something here. How do you feel about it?
Contributor
Author
There was a problem hiding this comment.
Oof that's a subtle one, the dataflow-to-here results pane in IntelliJ uses a proportional font in which "" and "'" are indistinguishable to my eyes.
Contributor
There was a problem hiding this comment.
Ahh this is a great workaround!
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2025/03/07/collectionToDelimitedString-useless-prefix-suffix
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 7, 2025
…ic#124353) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 7, 2025
…ic#124353) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 7, 2025
…ic#124353) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
…) (#124366) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
…) (#124365) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
…) (#124367) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
…ic#124353) These parameters are confusing and almost entirely unused (apart from one easily-adjusted test, two production locations where they are used incorrectly, and one production location that can be adjusted not to need them). This commit just removes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters are confusing and almost entirely unused (apart from
one easily-adjusted test, two production locations where they are used
incorrectly, and one production location that can be adjusted not to
need them). This commit just removes them.