Skip to content

[ML] Avoid unnecessary calls to Task#getDescription in model download #124527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

[ML] Avoid unnecessary calls to Task#getDescription in model download #124527

merged 3 commits into from
Mar 11, 2025

Conversation

@davidkyle
Copy link
Member

@davidkyle davidkyle commented Mar 10, 2025

The model download code checks for an existing download task by iterating over the currently running tasks comparing the task description. The call to getDescription() can sometimes throw- see the stack trace below.

This change rearranges the conditional check so that getDescription() is only called on instances of ModelDownloadTask.

Caused by: java.lang.UnsupportedOperationException: This should not be XContent serialized
	at [email protected]/org.elasticsearch.xpack.inference.rank.textsimilarity.TextSimilarityRankBuilder.doXContent(TextSimilarityRankBuilder.java:106)
	at [email protected]/org.elasticsearch.search.rank.RankBuilder.toXContent(RankBuilder.java:70)
	at [email protected]/org.elasticsearch.xcontent.XContentBuilder.value(XContentBuilder.java:993)
	at [email protected]/org.elasticsearch.xcontent.XContentBuilder.value(XContentBuilder.java:982)
	at [email protected]/org.elasticsearch.xcontent.XContentBuilder.field(XContentBuilder.java:974)
	at [email protected]/org.elasticsearch.search.builder.SearchSourceBuilder.innerToXContent(SearchSourceBuilder.java:1713)
	at [email protected]/org.elasticsearch.search.builder.SearchSourceBuilder.toXContent(SearchSourceBuilder.java:1852)
	at [email protected]/org.elasticsearch.common.xcontent.XContentHelper.toXContent(XContentHelper.java:653)
	at [email protected]/org.elasticsearch.common.xcontent.XContentHelper.toXContent(XContentHelper.java:633)
	at [email protected]/org.elasticsearch.search.builder.SearchSourceBuilder.toString(SearchSourceBuilder.java:2177)
	at [email protected]/org.elasticsearch.action.search.SearchRequest.buildDescription(SearchRequest.java:747)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1709)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:727)
Caused by: java.lang.UnsupportedOperationException: This should not be XContent serialized

	at [email protected]/org.elasticsearch.action.search.MultiSearchRequest$1.getDescription(MultiSearchRequest.java:381)
	at org.elasticsearch.xpack.ml.packageloader.action.TransportLoadTrainedModelPackage.handleDownloadInProgress(TransportLoadTrainedModelPackage.java:154)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 10, 2025

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Mar 10, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 10, 2025

Hi @davidkyle, I've created a changelog YAML for you.

@davidkyle davidkyle requested a review from Mikep86 March 10, 2025 21:42
kderusso
kderusso reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could we please also add a test for this case?

Mikep86
Mikep86 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this! Agree with Kathleen that a test would be nice, but this is such a straightforward change that we could do it in a follow-up if we just want to get the fix live ASAP.

@davidkyle davidkyle merged commit 444b8ea into elastic:main Mar 11, 2025
16 of 17 checks passed
This was referenced Mar 11, 2025
Merged
Merged
@Mikep86
Copy link
Contributor

Mikep86 commented Mar 11, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 9.0
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

@Mikep86 Mikep86 mentioned this pull request Mar 11, 2025
Merged
@davidkyle davidkyle added the auto-backport Automatically create backport pull requests when merged label Mar 11, 2025
@thecoop thecoop mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kderusso kderusso kderusso left review comments

@Mikep86 Mikep86 Mikep86 approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >bug :ml Machine learning Team:ML Meta label for the ML team v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidkyle @elasticsearchmachine @Mikep86 @kderusso