Revert "ESQL - Include thread names in profile output" #124576
Conversation
This reverts commit 3e94947.
elasticsearchmachine
added
needs:triage
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
Heya, I'm not sure if the transport version change might break things, so I'd like to flag this as blocked until we figured that out, sorry!
| @@ -180,7 +180,6 @@ static TransportVersion def(int id) { | |||
| public static final TransportVersion MAX_OPERATION_SIZE_REJECTIONS_ADDED = def(9_024_0_00); | |||
| public static final TransportVersion RETRY_ILM_ASYNC_ACTION_REQUIRE_ERROR = def(9_025_0_00); | |||
| public static final TransportVersion ESQL_SERIALIZE_BLOCK_TYPE_CODE = def(9_026_0_00); | |||
| public static final TransportVersion ESQL_THREAD_NAME_IN_DRIVER_PROFILE = def(9_027_0_00); | |||
There was a problem hiding this comment.
Erm, since the original PR had a TV change, we need to double check if this is actually safe to revert without breaking Serverless.
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
Nevermind, original PR was merged an hour ago - this is totally fine.
|
Upon review, we don't need to do this. #124312 is rebuilding the docs in the new location anyway, and should be merged before the deleted docs get deployed anywhere important. The transport version change makes this revert tricky (and thank you Alex for pointing that out, I'd forgotten that's a thing we need to be careful of), so if we do end up needing to restore these docs, we should do it via a new PR that only pulls forward the docs files. |
Reverts #124262
Somehow this deleted a bunch of extra files docs files. Will fix and just commit the intended change