[Inference API] Fix test for pre-adaptive rate limiting case #124709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgrein
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Mar 17, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an instance of a subclass of
BaseInferenceActionRequestgets initialized through the transport layer and the overall transport version is before adaptive rate limiting was added, thenhasBeenReroutedwill always be set totrue. This can fail in this test case as the default value for a primitive boolean isfalse(found & fixed in the backport). Therefore we need to handle this case inmutateInstanceForVersionspecifically.