Measure search load per index - Extend ThreadPool Executor #124853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pr to make visible the first approach of tracking the execution time per index by extending the ThreadPool Executor
We extended
TaskExecutionTimeTrackingEsThreadPoolExecutorthat already has logic to track globally (not per-index) EWMA and time spent executing tasks in the search thread pool to track on a per-index basis inTaskExecutionTimeTrackingPerIndexEsThreadPoolExecutor. We decided to extend this logic so that the time-tracking logic is not duplicated.We take care of new indices being tracked with the computeIfAbsent inside the trackExecutionTime method and take care of removing deleted indices with the cluster state listener
SearchIndexTimeTrackingCleanupService