Fix testCancelUnnecessaryRequests #124864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Mar 14, 2025
Comment on lines
-287
to
-296
| } catch (AssertionError e) { | ||
| client().admin().indices().stats(new IndicesStatsRequest()).actionGet().asMap().forEach((shard, stats) -> { | ||
| logger.info( | ||
| "Shard {} node {} status {} docs {}", | ||
| shard.shardId(), | ||
| shard.currentNodeId(), | ||
| shard.state(), | ||
| stats.getStats().getDocs().getCount() | ||
| ); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
This was not bubbling up exception if/when that happens
idegtiarenko
commented
Mar 14, 2025
| stats.getStats().getDocs().getCount() | ||
| ); | ||
| }); | ||
| assertThat(exchanges.get(), lessThanOrEqualTo(2)); |
Contributor
Author
There was a problem hiding this comment.
Once above was fixed I noticed that 1-8% depending on the load of the times the test was failing.
Since processing pages and sending more requests happens on different threads of different threadpools, we can not guarantee that incoming page is processed before the next request is sent.
It looks like in practice we accumulate enough results (1 row) before the third request is sent.
This still shows that we do not send request to every node (there are at minimum 3 data nodes in this test).
nik9000
approved these changes
Mar 19, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was silently skipping assertion.
Please see inline comments for more details.