Skip to content

Conversation

@prwhelan
Copy link
Member

@prwhelan prwhelan commented Mar 18, 2025

Remove the use of DelegatingProcessor and replace it with an inline processor.


Verified that metrics still publish:

{
  "_index": ".ds-metrics-apm.app.elasticsearch-default-2025.03.11-000001",
    "@timestamp": "2025-03-18T12:42:56.587Z",
    "numeric_labels": {
      "status_code": 200
    },
    "service": {
      "node": {
        "name": "runTask-0"
      },
      "version": "9.1.0"
    },
    "host": {
      "hostname": "whelan-elastic",
      "os": {
        "platform": "Linux"
      },
    },
    "metricset": {
      "name": "app"
    },
    "es.inference.requests.time": {
      "counts": [
        2
      ],
      "values": [
        9888.5
      ]
    },
    "labels": {
      "otel_instrumentation_scope_name": "elasticsearch",
      "service": "cohere",
      "rerouted": "false",
      "model_id": "command-r-plus-08-2024",
      "task_type": "completion",
    },
  },
}

Remove the use of DelegatingProcessor and replace it with an inline
processor.
@prwhelan prwhelan added >refactoring :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Mar 18, 2025
@prwhelan prwhelan marked this pull request as ready for review March 20, 2025 17:29
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

String localNodeId,
Flow.Processor<T, T> upstream
) {
return downstream -> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publisher has a single method subscribe, so when our downstream calls subscribe we will forward it to the upstream.subscribe, tying the upstream and downstream together with this function

@prwhelan prwhelan enabled auto-merge (squash) March 21, 2025 15:46
@prwhelan prwhelan merged commit b8db0ee into elastic:main Mar 21, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125092

prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Mar 21, 2025
Remove the use of DelegatingProcessor and replace it with an inline
processor.
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
Remove the use of DelegatingProcessor and replace it with an inline
processor.
prwhelan added a commit that referenced this pull request Mar 21, 2025
Remove the use of DelegatingProcessor and replace it with an inline
processor.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
Remove the use of DelegatingProcessor and replace it with an inline
processor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning >refactoring Team:ML Meta label for the ML team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants