Skip to content

Fixing muted tests and consolidating duplicate functions #125138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2025
Merged

Fixing muted tests and consolidating duplicate functions #125138

merged 3 commits into from
Mar 18, 2025

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Mar 18, 2025 •
edited
Loading

Resolves #125057
Resolves #125061
Resolves #125059

@ymao1 ymao1 self-assigned this Mar 18, 2025
@ymao1 ymao1 added >non-issue Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v8.19.0 :ml Machine learning labels Mar 18, 2025
@ymao1 ymao1 marked this pull request as ready for review March 18, 2025 19:04
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 18, 2025

Pinging @elastic/ml-core (Team:ML)

@ymao1 ymao1 merged commit a27f5ac into elastic:main Mar 18, 2025
17 checks passed
@ymao1 ymao1 deleted the input-type-followups branch March 18, 2025 19:08
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 18, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125138

@ymao1 ymao1 mentioned this pull request Mar 18, 2025
Merged
@ymao1
Copy link
Contributor Author

ymao1 commented Mar 18, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

ymao1 added a commit to ymao1/elasticsearch that referenced this pull request Mar 18, 2025
@ymao1
Fixing muted tests and small refactor to remove duplicate functions (e…
c18c131 
…lastic#125138)

(cherry picked from commit a27f5ac)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 19, 2025
@ymao1
[8.x] Fixing muted tests and small refactor to remove duplicate funct…
b52efa2 
…ions (#125138) (#125152)

* Fixing muted tests and small refactor to remove duplicate functions (#125138)

(cherry picked from commit a27f5ac)

# Conflicts:
#	muted-tests.yml

* Unmuting test
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
@ymao1 @smalyshev
Fixing muted tests and small refactor to remove duplicate functions (e…
d42529b 
…lastic#125138)
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@ymao1 @omricohenn
Fixing muted tests and small refactor to remove duplicate functions (e…
aeb1149 
…lastic#125138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees

@ymao1 ymao1

Labels

auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

3 participants

@ymao1 @elasticsearchmachine @jonathan-buttner