Update metrics command #125193
Update metrics command #125193
Conversation
dnhatn
added
:Analytics/ES|QL
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| @Override | ||
| protected LogicalPlan rule(EsRelation r) { | ||
| if (r.indexMode() == IndexMode.TIME_SERIES) { | ||
| if (r.output().stream().anyMatch(a -> a.name().equals(MetadataAttribute.TSID_FIELD)) == false) { |
There was a problem hiding this comment.
Due to their perf caracteristics, we're looking to move away from the streams - use
Expressions.anyMatch(r.output(), a -> MetadataAttributes.TSID_FIELD.equals(a.name()) == false) instead.
| /** | ||
| * Uses the standard index mode if the special index mode is not required in the query. | ||
| */ | ||
| public final class DropIndexMode extends OptimizerRules.OptimizerRule<EsRelation> { |
There was a problem hiding this comment.
how about PruneUnusedIndexMode ?
| null | ||
| ); | ||
| return new Aggregate(source, relation, Aggregate.AggregateType.METRICS, stats.groupings, stats.aggregates); | ||
| return visitRelation(source(ctx), "METRICS", ctx.indexPatternAndMetadataFields()); |
There was a problem hiding this comment.
I hate to say this, but this may get renamed again (there's some confusion with the name "metrics"..). Still, I think the rest of this PR should hold and this should be a much smaller change (?)
| EMPTY, | ||
| unresolvedTSRelation("foo"), | ||
| Aggregate.AggregateType.METRICS, | ||
| Aggregate.AggregateType.STANDARD, |
There was a problem hiding this comment.
For my education, don't we want to track all aggs right after METRICS as AggregateType.METRICS? In the sense that they're applied per-tsid by default?
There was a problem hiding this comment.
We are not using AggregateType now. We can adjust it later when we start using it.
|
Thanks friends! |
This change updates the METRICS command syntax from METRICS index_pattern aggregations | ... to METRICS index_pattern | ..., removing inline aggregations. This PR does not filter out non-time-series indexes from the source; this will be addressed in a follow-up PR to keep this PR small.
This change updates the METRICS command syntax from METRICS index_pattern aggregations | ... to METRICS index_pattern | ..., removing inline aggregations. This PR does not filter out non-time-series indexes from the source; this will be addressed in a follow-up PR to keep this PR small.
5 participants
This change updates the METRICS command syntax from
METRICS index_pattern aggregations | ...toMETRICS index_pattern | ..., removing inline aggregations. This PR does not filter out non-time-series indexes from the source; this will be addressed in a follow-up PR to keep this PR small.