Add exclusive file entitlement for settings #125272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>non-issue
test-entitlements
v8.18.1
v8.19.0
v9.0.1
v9.1.0
:Core/Infra/Entitlements
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Mar 20, 2025
|
|
||
| @Override | ||
| protected Path filesSetLastModifiedTime(Path path, FileTime time) throws IOException { | ||
| return Files.setLastModifiedTime(path, time); |
There was a problem hiding this comment.
Not sure how this one is working right now since we only have read access. IIRC this is an edge case for when we restore from a snapshot. We should (as a followup) re-consider how restoring from snapshots should interact with file settings because this breaks the rule that we want to use, only allowing read access to the config directory.
| FileData.ofRelativePath(Path.of(""), SHARED_REPO, READ_WRITE), | ||
|
|
||
| // exclusive settings file | ||
| FileData.ofRelativePath(Path.of("operator/settings.json"), CONFIG, READ).withExclusive(true), |
There was a problem hiding this comment.
Unfortunately I think this needs to be READ_WRITE, see my other comment.
|
@elasticmachine run elasticsearch-ci/part-3 |
elasticsearchmachine
added
the
serverless-linked
|
@elasticmachine run elasticsearch-ci/part-3 |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Apr 1, 2025
Adds changes to ensure the correct caller's module is checked for exclusive file settings.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Apr 1, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2025
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Apr 1, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes to ensure the correct caller's module is checked for exclusive file settings.
ES-11136