Skip to content

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented Mar 20, 2025

This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846

@ldematte ldematte added >docs General docs changes auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 20, 2025
@ldematte ldematte requested a review from a team March 20, 2025 10:42
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels Mar 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good 👍
Just a few minor optional nits ... but a native language expert either


{{es}} limits the ability to perform certain security-sensitive actions as part of its _Entitlement_ security mechanism (e.g. to limit the potential fallout from remote code execution (RCE) vulnerabilities).

The Entitlement model is _scope_-based: the subset of code to which we grant the ability to perform a security-sensitive action is called a _scope_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Entitlement model is _scope_-based: the subset of code to which we grant the ability to perform a security-sensitive action is called a _scope_.
The Entitlement model is _scope_-based: the subset of code to which the ability to perform a security-sensitive action is granted, is called a _scope_.

{{es}} limits the ability to perform certain security-sensitive actions as part of its _Entitlement_ security mechanism (e.g. to limit the potential fallout from remote code execution (RCE) vulnerabilities).

The Entitlement model is _scope_-based: the subset of code to which we grant the ability to perform a security-sensitive action is called a _scope_.
Currently, scope granularity is at java-module level; in other words, an _entitlement scope_ corresponds to a java module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, scope granularity is at java-module level; in other words, an _entitlement scope_ corresponds to a java module.
Currently, scope granularity is at the Java module level; in other words, an _entitlement scope_ corresponds to a Java module.

Copy link
Contributor

@prdoyle prdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of optional suggestions

Each of the 3 types has some additional fields:
- `mode` (required): can be either `read` or `read_write`
- `platform` (optional): if a path is specific to a platform. Can be `linux`, `macos` or `windows`. If not specified, the path is assumed to be valid on all platforms.
- `platform` (optional): indicates the entitlement groups be granted on only one platform, which can be one of `linux`, `macos` or `windows`. On other platforms, the entitlement is ignored. If this field is not specified, the entitlement is granted on all platforms.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this last "entitlement" be "entitlement groups"?

@ldematte ldematte enabled auto-merge (squash) March 21, 2025 08:20
@ldematte ldematte merged commit 3558a28 into elastic:main Mar 21, 2025
5 of 6 checks passed
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Mar 21, 2025
This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125292

elasticsearchmachine pushed a commit that referenced this pull request Mar 21, 2025
This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846
ldematte added a commit that referenced this pull request Mar 21, 2025
This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846
ldematte added a commit that referenced this pull request Mar 21, 2025
@ldematte ldematte deleted the entitlements/plugins-docs branch March 21, 2025 10:01
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Mar 21, 2025
This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
This PR updates the documentation for Creating classic plugins, replacing the instructions relative to the Java SecurityManager with information on Entitlements.

Relates to ES-10846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants