From 85ddb2525c88f419911338317c9d79c1bcc97040 Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Thu, 20 Mar 2025 12:35:14 +0100 Subject: [PATCH] Remove redundant `consumeAll` call on in QueryPhaseResultConsumer It's in the title, no need to call this for a null response. --- .../elasticsearch/action/search/QueryPhaseResultConsumer.java | 1 - 1 file changed, 1 deletion(-) diff --git a/server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java b/server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java index e81d659efe84f..7ae35021e38f4 100644 --- a/server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java +++ b/server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java @@ -385,7 +385,6 @@ private void consume(QuerySearchResult result, Runnable next) { result.consumeAll(); next.run(); } else if (result.isNull()) { - result.consumeAll(); SearchShardTarget target = result.getSearchShardTarget(); SearchShard searchShard = new SearchShard(target.getClusterAlias(), target.getShardId()); synchronized (this) {