Fix testProcessMultipleChunks #125304
Merged
Fix testProcessMultipleChunks #125304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreden
added
>test
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ywangd
approved these changes
Mar 24, 2025
| projectId, | ||
| namespace, | ||
| reservedStateChunks.getFirst().metadata().version(), | ||
| reservedStateChunks.isEmpty() ? null : reservedStateChunks.getFirst().metadata().version(), |
There was a problem hiding this comment.
I think we should use EMPTY_VERSION?
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
* Fix testProcessMultipleChunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is supposed to test a successful process of multiple reserved state chunks but the random chunk generation sometimes produced an empty list of chunks, so the processing failed (as expected). This caught a different error though, that I've corrected in this PR + fixed the test code.