-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Use ALL-UNNAMED for the unnamed module in warnings #125317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Mar 20, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
* Use ALL-UNNAMED for the unnamed module in warnings * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/Entitlements
Entitlements infrastructure
>non-issue
Team:Core/Infra
Meta label for core/infra team
v8.18.1
v8.19.0
v9.0.1
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
(null), report the module name asALL-UNNAMEDfor the unnamed module.This makes it simpler to describe what to do when one of these happens. If the user is going to grant an entitlement, they can simply take the given module name without any special cases.