Skip to content

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Mar 20, 2025

Instead of (null), report the module name as ALL-UNNAMED for the unnamed module.

This makes it simpler to describe what to do when one of these happens. If the user is going to grant an entitlement, they can simply take the given module name without any special cases.

@prdoyle prdoyle added >non-issue auto-backport Automatically create backport pull requests when merged test-entitlements v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 20, 2025
@prdoyle prdoyle self-assigned this Mar 20, 2025
@prdoyle prdoyle requested a review from a team as a code owner March 20, 2025 14:50
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 20, 2025
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle merged commit e061126 into elastic:main Mar 20, 2025
22 checks passed
@prdoyle prdoyle deleted the all-unnamed branch March 20, 2025 21:03
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x
9.0

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Mar 20, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Mar 21, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
* Use ALL-UNNAMED for the unnamed module in warnings

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants