[ML] Move and rename AmazonBedrockSecretSettings #125323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for integrating with SageMaker, we want to reuse the existing SecretSettings. - AmazonBedrockSecretSettings moved from services.amazonbedrock to common.amazon. - AmazonBedrockSecretSettings was renamed to AwsSecretSettings. - accessKey and secretKey are now encapsulated.
prwhelan
added
>refactoring
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Mar 20, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Mar 21, 2025
In preparation for integrating with SageMaker, we want to reuse the existing SecretSettings. - AmazonBedrockSecretSettings moved from services.amazonbedrock to common.amazon. - AmazonBedrockSecretSettings was renamed to AwsSecretSettings. - accessKey and secretKey are now encapsulated.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 21, 2025
In preparation for integrating with SageMaker, we want to reuse the existing SecretSettings. - AmazonBedrockSecretSettings moved from services.amazonbedrock to common.amazon. - AmazonBedrockSecretSettings was renamed to AwsSecretSettings. - accessKey and secretKey are now encapsulated.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
In preparation for integrating with SageMaker, we want to reuse the existing SecretSettings. - AmazonBedrockSecretSettings moved from services.amazonbedrock to common.amazon. - AmazonBedrockSecretSettings was renamed to AwsSecretSettings. - accessKey and secretKey are now encapsulated.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
In preparation for integrating with SageMaker, we want to reuse the existing SecretSettings. - AmazonBedrockSecretSettings moved from services.amazonbedrock to common.amazon. - AmazonBedrockSecretSettings was renamed to AwsSecretSettings. - accessKey and secretKey are now encapsulated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for integrating with SageMaker, we want to reuse the existing SecretSettings.