Remove redundant response parameter to onResponseSent()
#125326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nobody uses this parameter (except some tests that simply verify the otherwise-unused plumbing is connected). This commit removes it. Relates elastic#125163
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
original-brownbear
approved these changes
Mar 20, 2025
DaveCTurner
added
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Mar 20, 2025
Nobody uses this parameter (except some tests that simply verify the otherwise-unused plumbing is connected). This commit removes it. Relates #125163
|
Backported to |
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
…125326) Nobody uses this parameter (except some tests that simply verify the otherwise-unused plumbing is connected). This commit removes it. Relates elastic#125163
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
…125326) Nobody uses this parameter (except some tests that simply verify the otherwise-unused plumbing is connected). This commit removes it. Relates elastic#125163
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…125326) Nobody uses this parameter (except some tests that simply verify the otherwise-unused plumbing is connected). This commit removes it. Relates elastic#125163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody uses this parameter (except some tests that simply verify the
otherwise-unused plumbing is connected). This commit removes it.
Relates #125163