Skip to content

Move remaining check methods in RestEntitlementsCheckAction #125351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

Move remaining check methods in RestEntitlementsCheckAction #125351

merged 3 commits into from
Mar 21, 2025

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Mar 20, 2025

All future check methods should be found reflectively with the EntitlementTest annotation.

@rjernst
Move remaining check methods in RestEntitlementsCheckAction
18f10c0 
All future check methods should be found reflectively with the
EntitlementTest annotation.
@rjernst rjernst added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 20, 2025
@rjernst rjernst requested a review from a team as a code owner March 20, 2025 21:20
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 20, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 20, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@rjernst
Copy link
Member Author

rjernst commented Mar 21, 2025

@elasticmachine update branch

@rjernst rjernst enabled auto-merge (squash) March 21, 2025 17:50
@rjernst rjernst merged commit 02f12c8 into elastic:main Mar 21, 2025
17 checks passed
@rjernst rjernst mentioned this pull request Mar 21, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 21, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125351

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 21, 2025
@rjernst
Move remaining check methods in RestEntitlementsCheckAction (elastic#…
7bb2574 
…125351)

All future check methods should be found reflectively with the
EntitlementTest annotation.
elasticsearchmachine pushed a commit that referenced this pull request Mar 21, 2025
@rjernst
Move remaining check methods in RestEntitlementsCheckAction (#125351) (…
079f1c7 
…#125436)

All future check methods should be found reflectively with the
EntitlementTest annotation.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 21, 2025
@rjernst
Move remaining check methods in RestEntitlementsCheckAction (elastic#…
22f93be 
…125351)

All future check methods should be found reflectively with the
EntitlementTest annotation.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 21, 2025
@rjernst
Move remaining check methods in RestEntitlementsCheckAction (elastic#…
c0a6dad 
…125351)

All future check methods should be found reflectively with the
EntitlementTest annotation.
@rjernst rjernst deleted the entitlements/it_test_cleanup2 branch March 21, 2025 20:41
elasticsearchmachine pushed a commit that referenced this pull request Mar 21, 2025
@rjernst
Move remaining check methods in RestEntitlementsCheckAction (#125351) (…
8f6ac0a 
…#125442)

All future check methods should be found reflectively with the
EntitlementTest annotation.
elasticsearchmachine pushed a commit that referenced this pull request Mar 21, 2025
@rjernst
Move remaining check methods in RestEntitlementsCheckAction (#125351) (…
33dc75f 
…#125443)

* Move remaining check methods in RestEntitlementsCheckAction (#125351)

All future check methods should be found reflectively with the
EntitlementTest annotation.

* Fix compilation after #125442
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@rjernst @omricohenn
Move remaining check methods in RestEntitlementsCheckAction (elastic#…
842267c 
…125351)

All future check methods should be found reflectively with the
EntitlementTest annotation.
@prdoyle
Copy link
Contributor

prdoyle commented Apr 22, 2025

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rjernst @elasticsearchmachine @prdoyle @ldematte @elasticmachine