Set the level for zstd best speed to 1 #125375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change sets the zstd best speed level from 0 to 1. Compression level 0 means the default level will be used, which is level 3. The intent of speed is to use the fastest compression level so 1 is a more appropriate value. Note that zstd best speed is still under a feature flag so this change is just meant to evaluate the impact on our nightly benchmarks. Further testing is needed (wip) to remove the feature flag entirely.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Mar 21, 2025
jimczi
added
the
auto-backport
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Mar 21, 2025
This change sets the zstd best speed level from 0 to 1. Compression level 0 means the default level will be used, which is level 3. The intent of speed is to use the fastest compression level so 1 is a more appropriate value. Note that zstd best speed is still under a feature flag so this change is just meant to evaluate the impact on our nightly benchmarks. Further testing is needed (wip) to remove the feature flag entirely.
💚 Backport successful
|
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
This change sets the zstd best speed level from 0 to 1. Compression level 0 means the default level will be used, which is level 3. The intent of speed is to use the fastest compression level so 1 is a more appropriate value. Note that zstd best speed is still under a feature flag so this change is just meant to evaluate the impact on our nightly benchmarks. Further testing is needed (wip) to remove the feature flag entirely.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 21, 2025
This change sets the zstd best speed level from 0 to 1. Compression level 0 means the default level will be used, which is level 3. The intent of speed is to use the fastest compression level so 1 is a more appropriate value. Note that zstd best speed is still under a feature flag so this change is just meant to evaluate the impact on our nightly benchmarks. Further testing is needed (wip) to remove the feature flag entirely.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This change sets the zstd best speed level from 0 to 1. Compression level 0 means the default level will be used, which is level 3. The intent of speed is to use the fastest compression level so 1 is a more appropriate value. Note that zstd best speed is still under a feature flag so this change is just meant to evaluate the impact on our nightly benchmarks. Further testing is needed (wip) to remove the feature flag entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the zstd best speed level from 0 to 1. Compression level 0 means the default level will be used, which is level 3. The intent of best speed is to use the fastest compression level so 1 is a more appropriate value. Note that zstd best speed is still under a feature flag so this change is just meant to evaluate the impact on our nightly benchmarks.
Further testing is needed (wip) to remove the feature flag entirely.