Skip to content

Cosmetic fixes to repository-s3 #125397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2025
Merged

Cosmetic fixes to repository-s3 #125397

merged 2 commits into from
Mar 21, 2025

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Mar 21, 2025 •
edited
Loading

Relates AWS SDK v2 upgrade, this commit just pulls out some bits that
can go in first.

@DaveCTurner
Cosmetic fixes to repository-s3
c1b8ca0 
Relates AWS SDK v2 uprgade, this commit just pulls out some bits that
can go in first.
@DaveCTurner DaveCTurner added >non-issue :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.19.0 v9.1.0 labels Mar 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Mar 21, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 21, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

DiannaHohensee
DiannaHohensee approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@DiannaHohensee DiannaHohensee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We also use the ClientConfiguration constants in AwsS3ServiceImplTests.java, so ultimately we'll probably want something accessible there, too.

@DaveCTurner DaveCTurner added the auto-backport Automatically create backport pull requests when merged label Mar 21, 2025
@DaveCTurner DaveCTurner merged commit 4ce1d9c into elastic:main Mar 21, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 21, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125397

DaveCTurner added a commit that referenced this pull request Mar 21, 2025
@DaveCTurner
Cosmetic fixes to repository-s3 (#125397)
271b04f 
Relates AWS SDK v2 uprgade, this commit just pulls out some bits that
can go in first.
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
@DaveCTurner @smalyshev
Cosmetic fixes to repository-s3 (elastic#125397)
ab2db0e 
Relates AWS SDK v2 uprgade, this commit just pulls out some bits that
can go in first.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@DaveCTurner @omricohenn
Cosmetic fixes to repository-s3 (elastic#125397)
ed8701d 
Relates AWS SDK v2 uprgade, this commit just pulls out some bits that
can go in first.
@DaveCTurner DaveCTurner deleted the 2025/03/21/repository-s3-cosmetics branch April 2, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiannaHohensee DiannaHohensee DiannaHohensee approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaveCTurner @elasticsearchmachine @DiannaHohensee