-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Record action name for all outbound messages #125399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 3 commits into
elastic:main
from
DaveCTurner:2025/03/21/OutboundHandler-MessageDirection
Mar 21, 2025
Merged
Record action name for all outbound messages #125399
elasticsearchmachine
merged 3 commits into
elastic:main
from
DaveCTurner:2025/03/21/OutboundHandler-MessageDirection
Mar 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On outbound messages we know the action name whether it's a request or response, so we can report it in logs rather than just relying on the payload's type.
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
original-brownbear
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
Backport has to wait for #125163 to land in 8.x. |
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
On outbound messages we know the action name whether it's a request or response, so we can report it in logs rather than just relying on the payload's type.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
On outbound messages we know the action name whether it's a request or response, so we can report it in logs rather than just relying on the payload's type.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 3, 2025
On outbound messages we know the action name whether it's a request or response, so we can report it in logs rather than just relying on the payload's type. Backport of elastic#125399 to `8.x`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 3, 2025
* Record action name for all outbound messages On outbound messages we know the action name whether it's a request or response, so we can report it in logs rather than just relying on the payload's type. Backport of #125399 to `8.x` * Another null check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
backport pending
:Distributed Coordination/Network
Http and internode communication implementations
>non-issue
Team:Distributed Coordination
Meta label for Distributed Coordination team
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.