Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.

On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Mar 21, 2025
Copy link
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Mar 21, 2025
@elasticsearchmachine elasticsearchmachine merged commit 51d209e into elastic:main Mar 21, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/03/21/OutboundHandler-MessageDirection branch March 21, 2025 13:41
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125399

@DaveCTurner
Copy link
Contributor Author

Backport has to wait for #125163 to land in 8.x.

smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 3, 2025
On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.

Backport of elastic#125399 to `8.x`
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
* Record action name for all outbound messages

On outbound messages we know the action name whether it's a request or
response, so we can report it in logs rather than just relying on the
payload's type.

Backport of #125399 to `8.x`

* Another null check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending :Distributed Coordination/Network Http and internode communication implementations >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants