Ensure the tsdb doc values codec is used in ES87TSDBDocValuesFormatTests #125420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `ES87TSDBDocValuesFormat` is used in `ES87TSDBDocValuesFormatTests`'s tests.
martijnvg
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
@elasticmachine update branch |
dnhatn
approved these changes
Mar 21, 2025
The tests that are inherited do use the tsdb doc values codec, but the tests defined in |
|
The test base class sets the codec as default codec: https://github.com/apache/lucene/blob/b59a357e58611b86e4cc1643794e05dd17d71b08/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseIndexFileFormatTestCase.java#L220 This change doesn't change the codec being used, but will make it more clearer. |
martijnvg
added
the
auto-backport
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 21, 2025
…sts (elastic#125420) Ensure `ES87TSDBDocValuesFormat` is used in `ES87TSDBDocValuesFormatTests`'s tests.
This was referenced Mar 21, 2025
Merged
Merged
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 21, 2025
…sts (elastic#125420) Ensure `ES87TSDBDocValuesFormat` is used in `ES87TSDBDocValuesFormatTests`'s tests.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 21, 2025
…sts (elastic#125420) Ensure `ES87TSDBDocValuesFormat` is used in `ES87TSDBDocValuesFormatTests`'s tests.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…sts (elastic#125420) Ensure `ES87TSDBDocValuesFormat` is used in `ES87TSDBDocValuesFormatTests`'s tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
ES87TSDBDocValuesFormatis used inES87TSDBDocValuesFormatTests's tests.