Fix compilation and tests for customAuthzEngine #125469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>non-issue
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
ywangd
commented
Mar 23, 2025
Comment on lines
-59
to
+58
| Authentication authentication = Authentication | ||
| .newRealmAuthentication(new User("bar", "not_superuser"), new RealmRef("test", "test", "node")) | ||
| .runAs(new User("joe", "custom_superuser"), new RealmRef("test", "test", "node")); | ||
| Authentication authentication = Authentication.newRealmAuthentication( | ||
| new User("bar", "not_superuser"), | ||
| new RealmRef("test", "test", "node") | ||
| ).runAs(new User("joe", "custom_superuser"), new RealmRef("test", "test", "node")); |
There was a problem hiding this comment.
No real change here other than format. This module has not been properly formatted for a while. There are a few more places in the PR like this.
ywangd
commented
Mar 23, 2025
Comment on lines
-47
to
+49
| Map<String, Object> config | ||
| Map<String, Object> config, | ||
| ProjectId projectId |
There was a problem hiding this comment.
Not related to custom authz engine. But needs to be fixed as well so that CI can pass.
|
Thanks Ryan! |
|
Thanks Yang! |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 25, 2025
No compilation issue in this branch Relates: elastic#125469
This was referenced Mar 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
No compilation issue in this branch Relates: #125469
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 27, 2025
No compilation issue in this branch Relates: elastic#125469
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #123812