Add time-series aggregation operator #125537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Mar 25, 2025
| @Override | ||
| public Operator get(DriverContext driverContext) { | ||
| return new HashAggregationOperator(aggregators, () -> { | ||
| if (aggregatorMode.isInputPartial()) { |
There was a problem hiding this comment.
Double check, currently the input is not partial during the initial grouping by tsid on data node, right?
| * An interface indicates that this is a time-series aggregator and it requires time-series source | ||
| */ | ||
| public interface ToTimeSeriesAggregator extends ToAggregator { | ||
|
|
There was a problem hiding this comment.
Is the smoothing going to be added to implementations of this interface or to TimeSeriesAggregationOperator?
There was a problem hiding this comment.
I think this interface serves as a placeholder for detecting time-series aggregations that require _tsid and @timestamp, such as rate (last, ...).
|
Thanks @martijnvg. |
kkrik-es
reviewed
Mar 26, 2025
| true // we can enable optimizations as the inputs are vectors | ||
| ); | ||
| } else { | ||
| return new TimeSeriesBlockHash(timestampGroup.channel(), timestampGroup.channel(), driverContext.blockFactory()); |
There was a problem hiding this comment.
Shouldn't the first arg be tsidGroup?
dnhatn
added a commit
that referenced
this pull request
Mar 26, 2025
Fix the channel in TimeSeriesAggregationOperator. Relates #125537
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
We will need custom logic in the time-series aggregation operator, such as smoothing the rate across buckets. To address this, this PR introduces a TimeSeriesAggregationOperator that extends HashAggregationOperator to support the addition logic.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Fix the channel in TimeSeriesAggregationOperator. Relates elastic#125537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need custom logic in the time-series aggregation operator, such as smoothing the rate across buckets. To address this, this PR introduces a TimeSeriesAggregationOperator that extends HashAggregationOperator to support the addition logic.