Improve StatementParserTests error message #125568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Mar 25, 2025
| return new MapExpression(EMPTY, ees); | ||
| } | ||
|
|
||
| void expectError(String query, String errorMessage) { |
There was a problem hiding this comment.
This could just defer to expectError(String query, List<QueryParam> params, String errorMessage) with params given by new QueryParams().
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating ParsingException(s) the testing framework displays query only if exception is not thrown at all and not when the error message is different from the expected one.
This change adds the query to both cases.
It makes it much easier to troubleshot failures from tests that rely on a query generation and/or IdentifierGenerator.