Re-enable VerifyVersionConstantsIT #125605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
commented
Mar 25, 2025
| /** | ||
| * Sets the version of Elasticsearch. Defaults to {@link Version#CURRENT}. | ||
| */ | ||
| T version(String version); |
There was a problem hiding this comment.
Added this as a convenience as many of our tests use org.elasticsearch.Version so then you have to disambiguate imports which is annoying. Plus, we almost always inject this into the build as a system property, which is a string to begin with.
mark-vieira
commented
Mar 25, 2025
| } | ||
| } | ||
|
|
||
| tasks.register("verifyDocsLuceneVersion") { |
There was a problem hiding this comment.
This got moved to the :docs project since it made much more sense for it to live there.
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 25, 2025
(cherry picked from commit 6575106) # Conflicts: # qa/verify-version-constants/build.gradle
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 25, 2025
(cherry picked from commit 6575106) # Conflicts: # docs/build.gradle
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 25, 2025
(cherry picked from commit 6575106) # Conflicts: # qa/verify-version-constants/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 26, 2025
mark-vieira
added a commit
that referenced
this pull request
Mar 26, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported this project over to new testing framework and also re-enabled it since it had been muted for awhile.
Closes #97736