Using a consistent index template name to avoid undefined behavior #125624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Mar 25, 2025
|
Thanks for tracking this down @masseyke! |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 25, 2025
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 25, 2025
This was referenced Mar 25, 2025
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 26, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Test ingest simulate with index template substitutionswe created an index template with one name, and then provided an index template substitution with another name that matches the same pattern with the same priority (no priority). The behavior when you do this is undefined, and just depends on the order that a hash map returns them. In the old test framework, the same things were always in that hash map, so the same index template came out first, and it just happened to be the one that made the test work. @mark-vieira is changing out the test framework, and with that change the other index template always happens to come out first, so the test always fails. This change just uses a single index template name so that we avoid this undefined behavior.