Resolve bwc dependencies for packer cache #125625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwc builds are build against an empty Gradle userhome by now and this results in - downloading the gradle distro for each first bwc build - downloading build dependency on each fresh bwc build resulting in >1gb of dependencies resolved - downloading java toolchains not resolved otherwise on the first bwc build.
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
commented
Mar 25, 2025
| * for packer caching only | ||
| * see CacheCacheableTestFixtures. | ||
| * */ | ||
| protected MinioTestContainer() { |
There was a problem hiding this comment.
fixes another packer cache issue when caching docker images we rely on in our fixtures: https://buildkite.com/elastic/elasticsearch-vm-images/builds/671#0195c53c-d566-405c-9503-afc95a6e6706
|
We can track the impact of better bwc caching basically by using this GE view: https://gradle-enterprise.elastic.co/scans/performance?search.relativeStartTime=P28D&search.rootProjectNames=elasticsearch&search.tasks=extractedAssemble&search.timeZoneId=Europe%2FVienna |
jozala
approved these changes
Mar 26, 2025
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 26, 2025
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 26, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bwc builds are built against an empty Gradle userhome by now and this results in
Requiring less downloads on every ci build also results in more stable builds with less transient download errors like: https://gradle-enterprise.elastic.co/s/wcp3lfhkkhrqg/console-log/task/:distribution:bwc:staged:buildBwcLinuxTar?anchor=744&page=1