-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Failure Store] Authorization denial messages #125757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 14 commits into
elastic:main
from
n1v0lg:failure-store-authz-messages
Apr 1, 2025
Merged
[Failure Store] Authorization denial messages #125757
elasticsearchmachine
merged 14 commits into
elastic:main
from
n1v0lg:failure-store-authz-messages
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-security (Team:Security) |
slobodanadamovic
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
(left optional suggestions)
...curity/src/main/java/org/elasticsearch/xpack/security/authz/AuthorizationDenialMessages.java
Outdated
Show resolved
Hide resolved
...aRestTest/java/org/elasticsearch/xpack/security/failurestore/FailureStoreSecurityRestIT.java
Outdated
Show resolved
Hide resolved
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2025
This PR makes authorization denial messages account for privileges that grant access to the failure store. This is a minimal implementation that only displays information around failure store privileges for requests that include concrete names with the `::failures` selector. This avoids including irrelevant information in regular non-failures requests. We can improve on this in follow ups. Closes: ES-11158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
>non-issue
:Security/Authorization
Roles, Privileges, DLS/FLS, RBAC/ABAC
serverless-linked
Added by automation, don't add manually
Team:Security
Meta label for security team
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes authorization denial messages account for privileges that grant access to the failure store. This is a minimal implementation that only displays information around failure store privileges for requests that include concrete names with the
::failuresselector. This avoids including irrelevant information in regular non-failures requests. We can improve on this in follow ups.Closes: ES-11158