Skip to content

Return failure store privileges via get built-in privileges API #125852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

Return failure store privileges via get built-in privileges API #125852

merged 5 commits into from
Apr 1, 2025

Conversation

@slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Mar 28, 2025 •
edited
Loading

Return read_failure_store and manage_failure_store via GET /_security/privilege/_builtin API.

@slobodanadamovic slobodanadamovic self-assigned this Mar 28, 2025
@slobodanadamovic slobodanadamovic added >non-issue :Security/Security Security issues without another label Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.19.0 labels Mar 28, 2025
slobodanadamovic
slobodanadamovic commented Mar 31, 2025
View reviewed changes
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/privileges/11_builtin.yml
# an assertion for that
- length: { "cluster" : 62 }
- length: { "index" : 22 }
- length: { "index" : 24 }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test has been disabled in release builds for some time. I'll depend on that for now. We can remove it from the blacklist after feature flag removal.

@slobodanadamovic slobodanadamovic marked this pull request as ready for review March 31, 2025 15:39
@slobodanadamovic slobodanadamovic requested a review from n1v0lg March 31, 2025 15:39
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

n1v0lg
n1v0lg approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll need the same for the Serverless repo, too.

@slobodanadamovic
Copy link
Contributor Author

We'll need the same for the Serverless repo, too.

Right, I'll address Serverless too. Thanks! 👍

@slobodanadamovic slobodanadamovic merged commit c864c6c into elastic:main Apr 1, 2025
22 checks passed
@slobodanadamovic slobodanadamovic mentioned this pull request Apr 1, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Apr 1, 2025
@slobodanadamovic
Return failure store privileges via get built-in privileges API (elas…
e91f15a 
…tic#125852)

Return `read_failure_store` and `manage_failure_store` via 
`GET /_security/privilege/_builtin` API.
elasticsearchmachine pushed a commit that referenced this pull request May 8, 2025
@slobodanadamovic
[8.19] Return failure store privileges via get built-in privileges API (
1ec3fed 
#125852) (#126019)

* Return failure store privileges via get built-in privileges API (#125852)

Return `read_failure_store` and `manage_failure_store` via 
`GET /_security/privilege/_builtin` API.

* add failure store privileges to get-builtin-privileges API docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n1v0lg n1v0lg n1v0lg approved these changes

Assignees

@slobodanadamovic slobodanadamovic

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :Security/Security Security issues without another label Team:Security Meta label for security team v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slobodanadamovic @elasticsearchmachine @n1v0lg