[Failure Store] Manage-style privileges grant both data and failures access #125900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
changed the title
n1v0lg
changed the title
n1v0lg
added
>non-issue
v8.19.0
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
slobodanadamovic
approved these changes
Mar 31, 2025
...core/src/main/java/org/elasticsearch/xpack/core/security/authz/privilege/IndexPrivilege.java
Show resolved
Hide resolved
| combined.add(union(dataSelectorAccessPrivileges, actions, IndexComponentSelectorPredicate.DATA)); | ||
| } | ||
| if (false == dataAndFailuresSelectorAccessPrivileges.isEmpty()) { | ||
| combined.add(union(dataAndFailuresSelectorAccessPrivileges, Set.of(), IndexComponentSelectorPredicate.DATA_AND_FAILURES)); |
There was a problem hiding this comment.
nit: consider pre-sizing the combined hash set
n1v0lg
added
the
auto-merge-without-approval
💚 Backport successful
|
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Apr 2, 2025
Resolves elastic#126061 Relates to elastic#125900
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 2, 2025
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Apr 3, 2025
Adjusting the test assertion to account for the potential 3rd extra group (elastic#125900). Resolves elastic#126061 (cherry picked from commit 7b753d0) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
…lures access (#125900) (#126044) * [Failure Store] Manage-style privileges grant both data and failures access (#125900) It's more natural for `manage` and `manage_data_stream_lifecycle` to grant access to management style APIs both for regular data streams and their failure stores. This PR adds support for privileges to grant access to both data and failures selectors (without granting access to everything, à la `all`), and extends `manage` and `manage_data_stream_lifecycle` to grant failure store access, in addition to regular data stream access. `manage_failure_store` still grants failures-only access. * Fix imports --------- Co-authored-by: Slobodan Adamović <[email protected]>
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Adjusting the test assertion to account for the potential 3rd extra group (elastic#125900). Resolves elastic#126061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more natural for
manageandmanage_data_stream_lifecycleto grant access to management style APIs both for regular data streams and their failure stores.This PR adds support for privileges to grant access to both data and failures selectors (without granting access to everything, à la
all), and extendsmanageandmanage_data_stream_lifecycleto grant failure store access, in addition to regular data stream access.manage_failure_storestill grants failures-only access.