Adding a cleanup method to EnterpriseGeoIpDownloaderIT #125958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
approved these changes
Mar 31, 2025
masseyke
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 31, 2025
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 7a9edb5) # Conflicts: # modules/ingest-geoip/src/internalClusterTest/java/org/elasticsearch/ingest/geoip/EnterpriseGeoIpDownloaderIT.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 7a9edb5) # Conflicts: # modules/ingest-geoip/src/internalClusterTest/java/org/elasticsearch/ingest/geoip/EnterpriseGeoIpDownloaderIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnterpriseGeoIpDownloaderIT fails, but rarely (see #115163). We're currently unable to run the test repeatedly to attempt to reproduce failure using
-Dtests.iters. This test cleans up the database configurations after the test completes so that it is in a state that can run again. I also suspect that this change might fix the failures (I don't have any direct evidence of that, but I was able to reproduce the failure in that ticket when I artificially ran this test without properly cleaning up).