Skip to content

Conversation

@craigtaverner
Copy link
Contributor

@craigtaverner craigtaverner commented Mar 31, 2025

Some specific requests from Kibana, as described in #125931

In particular:

  • Remove all links (both asciidoc and markdown) from the JSON definition files.
    • This required a two phase edit, from asciidoc links to markdown, and then removal of markdown (replace with markdown text). This is because the asciidoc does not have the display text, and because some links were already markdown.
  • Split predicates into is_null and is_not_null
    • We kept the old combined version because the main docs still use that, so now we have both combined and separate versions, and Kibana can select the version they want.

Fixes #125931

@craigtaverner craigtaverner added >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.1 v9.1.0 labels Mar 31, 2025
@craigtaverner craigtaverner requested a review from stratoula March 31, 2025 18:59
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Mar 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanx Craig!

"type" : "operator",
"operator" : "predicates",
"name" : "is_not_null",
"description" : "Use `IS NOT NULL` to filter data based on whether the field exists or not:",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description" : "Use `IS NOT NULL` to filter data based on whether the field exists or not:",
"description" : "Use `IS NOT NULL` to filter data based on whether the field exists or not.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made this change in the source document, so it will be generated here.

-->

### IS_NOT_NULL
Use `IS NOT NULL` to filter data based on whether the field exists or not:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use `IS NOT NULL` to filter data based on whether the field exists or not:
Use `IS NOT NULL` to filter data based on whether the field exists or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made this change in the source document, so it will be generated here.

@craigtaverner craigtaverner merged commit 7b263b4 into elastic:main Apr 1, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0

craigtaverner added a commit to craigtaverner/elasticsearch that referenced this pull request Apr 1, 2025
…lastic#125986)

In particular:
* Remove all links (both asciidoc and markdown) from the JSON definition files.
  * This required a two phase edit, from asciidoc links to markdown, and then removal of markdown (replace with markdown text). This is because the asciidoc does not have the display text, and because some links were already markdown.
* Split predicates into is_null and is_not_null
  * We kept the old combined version because the main docs still use that, so now we have both combined and separate versions, and Kibana can select the version they want.
@craigtaverner craigtaverner deleted the kibana-esql-docs-updates branch April 1, 2025 13:56
elasticsearchmachine pushed a commit that referenced this pull request Apr 1, 2025
…125986) (#126039)

In particular:
* Remove all links (both asciidoc and markdown) from the JSON definition files.
  * This required a two phase edit, from asciidoc links to markdown, and then removal of markdown (replace with markdown text). This is because the asciidoc does not have the display text, and because some links were already markdown.
* Split predicates into is_null and is_not_null
  * We kept the old combined version because the main docs still use that, so now we have both combined and separate versions, and Kibana can select the version they want.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ES|QL] improvements to the definitions / docs kibana files

3 participants