-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Kibana updates, remove links from JSON and split is-null/is-not-null #125986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kibana updates, remove links from JSON and split is-null/is-not-null #125986
Conversation
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanx Craig!
| "type" : "operator", | ||
| "operator" : "predicates", | ||
| "name" : "is_not_null", | ||
| "description" : "Use `IS NOT NULL` to filter data based on whether the field exists or not:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "description" : "Use `IS NOT NULL` to filter data based on whether the field exists or not:", | |
| "description" : "Use `IS NOT NULL` to filter data based on whether the field exists or not.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've made this change in the source document, so it will be generated here.
| --> | ||
|
|
||
| ### IS_NOT_NULL | ||
| Use `IS NOT NULL` to filter data based on whether the field exists or not: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Use `IS NOT NULL` to filter data based on whether the field exists or not: | |
| Use `IS NOT NULL` to filter data based on whether the field exists or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've made this change in the source document, so it will be generated here.
💚 Backport successful
|
…lastic#125986) In particular: * Remove all links (both asciidoc and markdown) from the JSON definition files. * This required a two phase edit, from asciidoc links to markdown, and then removal of markdown (replace with markdown text). This is because the asciidoc does not have the display text, and because some links were already markdown. * Split predicates into is_null and is_not_null * We kept the old combined version because the main docs still use that, so now we have both combined and separate versions, and Kibana can select the version they want.
…125986) (#126039) In particular: * Remove all links (both asciidoc and markdown) from the JSON definition files. * This required a two phase edit, from asciidoc links to markdown, and then removal of markdown (replace with markdown text). This is because the asciidoc does not have the display text, and because some links were already markdown. * Split predicates into is_null and is_not_null * We kept the old combined version because the main docs still use that, so now we have both combined and separate versions, and Kibana can select the version they want.
Some specific requests from Kibana, as described in #125931
In particular:
Fixes #125931