Fix cat allocation YAML test #126003
Merged
Fix cat allocation YAML test #126003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failed when the `disk.indices.forecast` value was more than 0 - with a decimal. We adjust the regex to allow non-zero values. Fixes elastic#125711 Fixes elastic#125848 Fixes elastic#125661
nielsbauman
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
commented
Mar 31, 2025
| [-\w.]+ \s+ | ||
| [-\w.]+ \s+ | ||
| [\w]+ | ||
| [-\w.]+ |
There was a problem hiding this comment.
I tried finding out if something changed in the computation of that field - i.e. if it's a bug that we're returning a non-zero value - but wasn't able to identify anything.
joegallo
approved these changes
Apr 1, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Apr 1, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Apr 1, 2025
This test failed when the `disk.indices.forecast` value was a decimal number. We adjust the regex to allow decimal values and for consistency we also allow negative values. Fixes elastic#125711 Fixes elastic#125848 Fixes elastic#125661 (cherry picked from commit 8028d5a) # Conflicts: # muted-tests.yml
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Apr 1, 2025
This test failed when the `disk.indices.forecast` value was a decimal number. We adjust the regex to allow decimal values and for consistency we also allow negative values. Fixes elastic#125711 Fixes elastic#125848 Fixes elastic#125661 (cherry picked from commit 8028d5a) # Conflicts: # muted-tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed when the
disk.indices.forecastvalue was a decimal number.We adjust the regex to allow decimal values and for consistency we also allow negative values.
Fixes #125711
Fixes #125848
Fixes #125661