From 0c30052662bdfe2fdf5b674179fe9c445bc7631e Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Thu, 6 Feb 2025 03:50:32 +0100 Subject: [PATCH] Remove redundant list copy in CanMatchNodeRequest (#121700) We're not mutating that list ever, so lets just use an immutable list all the way here and avoid at least one round of needless copy. --- .../org/elasticsearch/action/search/CanMatchNodeRequest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/main/java/org/elasticsearch/action/search/CanMatchNodeRequest.java b/server/src/main/java/org/elasticsearch/action/search/CanMatchNodeRequest.java index ba1afaf4678fb..75908c3fa77bd 100644 --- a/server/src/main/java/org/elasticsearch/action/search/CanMatchNodeRequest.java +++ b/server/src/main/java/org/elasticsearch/action/search/CanMatchNodeRequest.java @@ -136,7 +136,7 @@ public CanMatchNodeRequest( ) { this.source = getCanMatchSource(searchRequest); this.indicesOptions = indicesOptions; - this.shards = new ArrayList<>(shards); + this.shards = shards; this.searchType = searchRequest.searchType(); this.requestCache = searchRequest.requestCache(); // If allowPartialSearchResults is unset (ie null), the cluster-level default should have been substituted