From a107343c95879bb6dcc09dad7840619ce316f7bb Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Wed, 9 Apr 2025 19:20:34 -0400 Subject: [PATCH] ESQL: Fix bug in octal ip parsing tests (#126552) This fixes a bug in the tests for parsing ipv4 addresses with leading zeros as octal numbers. The bug was in the expectation code that we use for random input ips. Closes #126496 --- .../esql/expression/function/scalar/convert/ParseIpTests.java | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ParseIpTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ParseIpTests.java index 1a7a78a880dbf..fab3bc79cda54 100644 --- a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ParseIpTests.java +++ b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ParseIpTests.java @@ -191,6 +191,7 @@ public static String leadingZerosAreOctalToIp(String ip) { lastWasBreak = true; b.append(current).append('.'); current = 0; + octalMode = false; continue; } lastWasBreak = false;