Simplify DataNodeRequestSender #126664
Merged
Simplify DataNodeRequestSender #126664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Apr 11, 2025
| ) { | ||
| final long startTimeInNanos = System.nanoTime(); | ||
| searchShards(rootTask, clusterAlias, requestFilter, concreteIndices, originalIndices, ActionListener.wrap(targetShards -> { | ||
| searchShards(requestFilter, concreteIndices, originalIndices, ActionListener.wrap(targetShards -> { |
There was a problem hiding this comment.
Both available as fields, no need to pass them
idegtiarenko
commented
Apr 11, 2025
| take(sent, 3), | ||
| containsInAnyOrder(nodeRequest(node1, shard1, shard5), nodeRequest(node4, shard2), nodeRequest(node2, shard3, shard4)) | ||
| ); | ||
| assertThat(take(sent, 2), containsInAnyOrder(nodeRequest(node2, shard2), nodeRequest(node3, shard5))); |
There was a problem hiding this comment.
Lets compare domain objects rather than maps of lists
There was a problem hiding this comment.
FWIW you can do matchesMap() and get lovely error messaging. If you want. But I have no objections to comparing any way you like.
nik9000
approved these changes
Apr 11, 2025
| take(sent, 3), | ||
| containsInAnyOrder(nodeRequest(node1, shard1, shard5), nodeRequest(node4, shard2), nodeRequest(node2, shard3, shard4)) | ||
| ); | ||
| assertThat(take(sent, 2), containsInAnyOrder(nodeRequest(node2, shard2), nodeRequest(node3, shard5))); |
There was a problem hiding this comment.
FWIW you can do matchesMap() and get lovely error messaging. If you want. But I have no objections to comparing any way you like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups I would like to merge before #126653