Skip to content

Fix RepositoriesFileSettingsIT to wait for metadataVersion #126720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

Fix RepositoriesFileSettingsIT to wait for metadataVersion #126720

merged 2 commits into from
Apr 11, 2025

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Apr 11, 2025

Taking @n1v0lg's advice here, added a wait to make sure we have the right metadata version before proceeding with assertions.

Appears to work locally, though it already did.

Fixes #116694.

@prdoyle prdoyle added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Apr 11, 2025
@prdoyle prdoyle requested a review from n1v0lg April 11, 2025 18:46
@prdoyle prdoyle self-assigned this Apr 11, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Apr 11, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 11, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst
rjernst approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle enabled auto-merge (squash) April 11, 2025 18:52
@prdoyle
Copy link
Contributor Author

prdoyle commented Apr 11, 2025

:old-man-yells-at-spotless:

@prdoyle prdoyle merged commit 5c5a87a into elastic:main Apr 11, 2025
17 checks passed
@prdoyle prdoyle mentioned this pull request Apr 11, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 11, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126720

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Apr 11, 2025
@prdoyle
Fix RepositoriesFileSettingsIT to wait for metadataVersion (elastic#1…
9fd441b 
…26720)
This was referenced Apr 11, 2025
Closed
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 11, 2025
@prdoyle
Fix RepositoriesFileSettingsIT to wait for metadataVersion (#126720) (#…
c9832dd 
…126726)
elasticsearchmachine pushed a commit that referenced this pull request Apr 14, 2025
@prdoyle
Fix RepositoriesFileSettingsIT to wait for metadataVersion (#126720) (#…
820e0c1 
…126728)
@prdoyle prdoyle mentioned this pull request Apr 14, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 14, 2025
@prdoyle
Fix RepositoriesFileSettingsIT to wait for metadataVersion (#126720) (#…
2af113d 
…126728) (#126781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

@n1v0lg n1v0lg Awaiting requested review from n1v0lg

Assignees

@prdoyle prdoyle

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] RepositoriesFileSettingsIT testSettingsApplied failing

3 participants

@prdoyle @elasticsearchmachine @rjernst