Fix and unmute SemanticInferenceMetadataFieldsRecoveryTests #126784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the TranslogOperationAsserter to compare the raw operations. Closes elastic#124383 Closes elastic#124384 Closes elastic#124385
jimczi
added
>test
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Mikep86
approved these changes
Apr 14, 2025
Contributor
Mikep86
left a comment
Mikep86
left a comment
There was a problem hiding this comment.
LGTM. Should we backport to 8.18/9.0 to fix the flaky tests there as well?
...inference/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldTests.java
Show resolved
Hide resolved
jimczi
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Apr 15, 2025
…126784) Use the TranslogOperationAsserter to compare the raw operations. Closes elastic#124383 Closes elastic#124384 Closes elastic#124385
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Apr 16, 2025
…126784) Use the TranslogOperationAsserter to compare the raw operations. Closes elastic#124383 Closes elastic#124384 Closes elastic#124385
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Aug 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the TranslogOperationAsserter to compare the raw operations.
Closes #124383
Closes #124384
Closes #124385