ESQL: Move originalTypes method to FieldAttribute
#126838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves originalTypes() from Attribute to FieldAttribute, since only a FieldAttribute (and its subclasses) can refer to a field with multiple types.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
.../plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/TransportEsqlQueryAction.java
Outdated
Show resolved
Hide resolved
idegtiarenko
approved these changes
Apr 15, 2025
nik9000
reviewed
Apr 15, 2025
| @Nullable | ||
| public List<String> originalTypes() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
If we're going to move it, maybe just put it in UnsupportedAttribute. I don't like that either, but it feels better than this in the middle spot.
There was a problem hiding this comment.
I think we wanted to keep it on FieldAttribute level as we might want to create one (or subtype) from a MultiTypeEsField at some point. But anyways I pushed it further down now and we can revise this if/when needed.
nik9000
approved these changes
Apr 16, 2025
bpintea
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
originalTypes()fromAttributetoFieldAttribute, since only aFieldAttribute(and its subclasses) can refer to a field with multiple types.Addresses: https://github.com/elastic/elasticsearch/pull/124913/files#r1996239008